Mark client dependencies as devDependencies #3774
Open
+637
−109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change reclassifies client dependencies as devDependencies, resulting in a significant reduction (~100MB) in the Docker image size without affecting functionality.
I needed to mark
cross-env
as a regular dependency instead of a devDependency as it is used in thebackend
script which in turn is used by theDockerfile
. Things were working properly before due the client package declaringcross-env
as a dependency (incorrectly?). An alternative approach could be to run the backend withnode server/index.js
(as inDockerfile.multi
) and keepcross-env
as a devDependency.Testing
For testing
Dockerfile
:For testing
Dockerfile.multi
:I also ran both
test:client
andtest:api
. Wasn't able to get playwright working properly so didn't rune2e
tests.Test Configuration:
Checklist