Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make minor improvements to GitHub actions #577

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Make minor improvements to GitHub actions #577

merged 3 commits into from
Jan 31, 2025

Conversation

ydah
Copy link
Contributor

@ydah ydah commented Jan 31, 2025 •
edited
Loading

Make minor improvements to GitHub actions

  • Update GitHub Actions workflow to use GitHub format for standardrb

image

  • Ensure that the standardrb job is performed only once
    • This should only need to be done once, not for each matrix.
  • Use rake test:all instead of bundle exec rake bundle exec rake forked_tests bundle exec rake benchmarks bundle exec rake benchmarks:memory

danmayer
danmayer approved these changes Jan 31, 2025
View reviewed changes
Copy link
Owner

@danmayer danmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@danmayer danmayer merged commit 34dc51b into danmayer:main Jan 31, 2025
65 checks passed
@ydah ydah deleted the use-github-format branch January 31, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmayer danmayer danmayer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ydah @danmayer