add BackgroundForMultiProcess #572
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FeLvi-zzz
force-pushed
the
improve-resque-reporter-performance
branch
from
7c43907 to
f5b8dd8
Compare
|
I guess if this is a problem you have hit I could accept this PR, but make it opt-in so it would be off by default for resque users and can optionally be added when folks need the additional complexity. |
|
Yes, I guess almost all users don't need this function; it should be opt-in. In fact, we have already installed Coverband in some services, and they're not having any issues. I'm only having trouble with our largest service. |
|
thanks sounds good just tag me again when ready for a full review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background
our production servers process a lot of resque jobs.
Coverband::ResqueWorker#perform reports when the job finished, so CPU utilization of our Redis store for collection coverage data goes too high.
what I did
before sending reports to redis, an resque job saves coverage data to file(this should be on tmpfs).
background collector searches, collects and merges those files, and send to redis periodically.
TODO before opening PR