New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update README.md to have track_views default as true #496

Merged

danmayer merged 1 commit into danmayer:main from khaled-badenjki:docs/update-track-views-default-values

Dec 31, 2023

khaled-badenjki commented Dec 17, 2023

As per the code here
https://github.com/danmayer/coverband/blob/main/lib/coverband/configuration.rb#L72

and after testing it locally, the default value for track_views is true, while in the README.md file it says it's false.

In this PR i'm trying to resolve this problem


          update README.md

d952daa

danmayer approved these changes

View reviewed changes

danmayer merged commit d0b77ab into danmayer:main

64 checks passed

Owner

danmayer commented Dec 31, 2023

thanks for improving the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet