Drop support for older rubies, rails and redis

Author: fatkodima

.github/workflows/main.yml

@@ -19,10 +19,14 @@ jobs:
         # truffleruby,
         # truffleruby-head,
         # removing jruby again to flaky
-        gemfile: [ Gemfile.rails6.0, Gemfile.rails6.1, Gemfile.rails7.0, Gemfile.rails7.1 ]
+        gemfile: [ Gemfile.rails7.0, Gemfile.rails7.1, Gemfile.rails7.2, Gemfile.rails8.0 ]
         # need to add support for multiple gemfiles
-        ruby: ["2.7", "3.0", "3.1", "3.2", "3.3"]
+        ruby: ["3.1", "3.2", "3.3"]
         redis-version: [4, 5, 6, 7]
+        exclude:
+          # Rails 8 requires ruby 3.2+.
+          - gemfile: 'rails_8.0'
+            ruby: '3.1'
     runs-on: ${{ matrix.os }}-latest
     steps:
       - uses: actions/checkout@v4

.gitignore

@@ -24,4 +24,4 @@ temp_results
 .env
 log/
 test/unique_files
-test/rails5_dummy/tmp
+test/rails7_dummy/tmp

.rubocop.yml

@@ -2,4 +2,4 @@ require: standard
 
 inherit_gem:
   standard:
-    - config/ruby-2.7.yml
+    - config/ruby-3.1.yml

Gemfile

@@ -4,7 +4,7 @@ source "https://rubygems.org"
 
 # Specify your gem's dependencies in coverband.gemspec
 gemspec
-gem "rails", "~>7"
+gem "rails" # latest
 gem "haml"
 gem "slim"
 gem "webrick"

Gemfile.rails6.1

@@ -4,7 +4,7 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in coverband.gemspec
 gemspec
-gem 'rails', '~>7'
+gem 'rails', '~>7.2.0'
 gem "haml"
 gem "slim"
-gem "webrick"
+gem "webrick"

Gemfile.rails7 Gemfile.rails7.2

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
 # Specify your gem's dependencies in coverband.gemspec
 gemspec
-gem "rails", "~>6.0.0"
+gem 'rails', '~>8.0.0'
 gem "haml"
 gem "slim"
 gem "webrick"

Gemfile.rails6.0 Gemfile.rails8.0

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
   spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.require_paths = %w[lib]
 
-  spec.required_ruby_version = ">= 2.7"
+  spec.required_ruby_version = ">= 3.1"
 
   spec.metadata = {
     "homepage_uri" => "https://github.com/danmayer/coverband",

README.md

@@ -109,7 +109,7 @@ def save_report
 
       # This is the basic rails version supported, if there is something more unique over ride in subclass
       def self.supported_version?
-        defined?(Rails) && defined?(Rails::VERSION) && Rails::VERSION::STRING.split(".").first.to_i >= 5
+        defined?(Rails::VERSION) && Rails::VERSION::STRING.split(".").first.to_i >= 7
       end
 
       def route

coverband.gemspec

@@ -13,7 +13,7 @@ class RouteTracker < AbstractTracker
       TITLE = "Routes"
 
       def initialize(options = {})
-        if Rails&.respond_to?(:version) && Gem::Version.new(Rails.version) >= Gem::Version.new("6.0.0") && Gem::Version.new(Rails.version) < Gem::Version.new("7.1.0")
+        if Rails&.respond_to?(:version) && Gem::Version.new(Rails.version) < Gem::Version.new("7.1.0")
           require_relative "../utils/rails6_ext"
         end
 
@@ -52,7 +52,7 @@ def track_key(payload)
       end
 
       def self.supported_version?
-        defined?(Rails) && defined?(Rails::VERSION) && Rails::VERSION::STRING.split(".").first.to_i >= 6
+        defined?(Rails) && defined?(Rails::VERSION) && Rails::VERSION::STRING.split(".").first.to_i >= 7
       end
 
       def unused_keys(used_keys = nil)

lib/coverband/collectors/abstract_tracker.rb

@@ -24,7 +24,7 @@ def save_report
       end
 
       def self.supported_version?
-        defined?(Rails) && defined?(Rails::VERSION) && Rails::VERSION::STRING.split(".").first.to_i >= 4
+        defined?(Rails::VERSION) && Rails::VERSION::STRING.split(".").first.to_i >= 7
       end
 
       private

lib/coverband/collectors/route_tracker.rb

@@ -78,16 +78,12 @@ def teardown
   end
 
   test "using coverage state idle with ruby >= 3.1.0" do
-    return unless Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.1.0")
-
     ::Coverage.expects(:state).returns(:idle)
     ::Coverage.expects(:start).with(oneshot_lines: false)
     Coverband::Collectors::Coverage.send(:new)
   end
 
   test "using coverage state suspended with ruby >= 3.1.0" do
-    return unless Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.1.0")
-
     ::Coverage.expects(:state).returns(:suspended).at_least_once
     ::Coverage.expects(:resume)
     Coverband::Collectors::Coverage.send(:new)

lib/coverband/collectors/view_tracker_service.rb

@@ -1,3 +1,15 @@
 # frozen_string_literal: true
 
-require_relative "../../rails5_dummy/config/coverband"
+Coverband.configure do |config|
+  # NOTE: we reuse this config in each of the fake rails projects
+  # the below ensures the root is set to the correct fake project
+  config.root = ::File.expand_path("../../../", __FILE__).to_s + "/rails#{Rails::VERSION::MAJOR}_dummy"
+  config.store = Coverband::Adapters::RedisStore.new(Redis.new(db: 2, url: ENV["REDIS_URL"]), redis_namespace: "coverband_test") if defined? Redis
+  config.ignore = %w[.erb$ .slim$]
+  config.root_paths = []
+  config.logger = Rails.logger
+  config.verbose = true
+  config.background_reporting_enabled = true
+  config.track_routes = true
+  config.use_oneshot_lines_coverage = true if ENV["ONESHOT"]
+end

test/coverband/collectors/coverage_test.rb

@@ -1,3 +1,14 @@
 # frozen_string_literal: true
 
-require_relative "../../rails5_dummy/config/coverband_missing_redis"
+Coverband.configure do |config|
+  config.root = Dir.pwd
+  config.store = Coverband::Adapters::RedisStore.new(Redis.new(db: 2, url: "redis://127.0.0.1:123"), redis_namespace: "coverband_test") if defined? Redis
+  config.ignore = %w[vendor .erb$ .slim$]
+  config.root_paths = []
+  config.logger = Rails.logger
+  config.verbose = true
+  config.background_reporting_enabled = true
+  config.track_gems = true
+  config.gem_details = true
+  config.use_oneshot_lines_coverage = true if ENV["ONESHOT"]
+end