Skip to content

Commit 08806db

Browse files
committed
fix and add benchmarks to CI
1 parent 53509b7 commit 08806db

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

.github/workflows/main.yml

+2
Original file line numberDiff line numberDiff line change
@@ -36,4 +36,6 @@ jobs:
3636
- run: bundle exec standardrb
3737
- run: bundle exec rake
3838
- run: bundle exec rake forked_tests
39+
- run: bundle exec rake benchmarks
40+
- run: bundle exec rake benchmarks:memory
3941
- run: "RUBYOPT='--enable=frozen-string-literal --debug=frozen-string-literal' bundle exec rake"

Rakefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ RuboCop::RakeTask.new
88

99
task default: %i[test]
1010

11-
task "test:all": %i[rubocop test forked_tests benchmarks:memory benchmarks]
11+
task "test:all": %i[test forked_tests benchmarks:memory benchmarks]
1212

1313
task :test
1414
require "rake/testtask"

test/benchmarks/benchmark.rake

+5-3
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,9 @@ namespace :benchmarks do
9898
Coverband::Collectors::Coverage.instance.reset_instance
9999
end
100100

101-
lines = 45
102-
non_nil_lines = 18
103101
def fake_line_numbers
102+
lines = 45
103+
non_nil_lines = 18
104104
lines.times.map do |line|
105105
coverage = (line < non_nil_lines) ? rand(5) : nil
106106
end
@@ -155,6 +155,7 @@ namespace :benchmarks do
155155

156156
def measure_memory
157157
require "memory_profiler"
158+
require "stringio"
158159
report = fake_report
159160
store = benchmark_redis_store
160161
store.clear!
@@ -249,6 +250,7 @@ namespace :benchmarks do
249250

250251
desc "checks memory of collector"
251252
task memory_check: [:setup] do
253+
require "stringio"
252254
require "objspace"
253255
puts "memory load check"
254256
puts(ObjectSpace.memsize_of_all / 2**20)
@@ -316,7 +318,7 @@ namespace :benchmarks do
316318
desc "runs memory leak check via Rails tests"
317319
task memory_rails: [:setup] do
318320
puts "runs memory rails test to ensure we dont leak"
319-
puts `COVERBAND_MEMORY_TEST=true bundle exec test/forked/rails_full_stack_test.rb`
321+
puts `COVERBAND_MEMORY_TEST=true bundle exec ruby -I test test/forked/rails_full_stack_test.rb`
320322
end
321323

322324
desc "runs memory leak checks"

0 commit comments

Comments
 (0)