A race condiiton could occur when setting the redis for the view tracker

This commit moves the creation of the view tracker and subscription to active support notifications until after we have run the users custom config block... previously the view tracker would run before a users custom config could set the store `config.store` with a redis URL... So it would default to REDIS_URL from the env, even if the user set it to say COVERBAND_REDIS_URL in their custom config... This bug could only effect folks that had multiple redises and were trying to run Coverband on a Redis that wasn't associated with the REDIS_URL env. When this bug occered we would save view_tracker information tot he REDIS_URL redis instance and then report them from the on configured by the users custom config.
danmayer · Sep 7, 2020 · 08726b5 · 08726b5 · kbaum · Sep 8, 2020
1 parent db6969b
commit 08726b5
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 10 deletions.
diff --git a/lib/coverband/utils/railtie.rb b/lib/coverband/utils/railtie.rb
@@ -13,7 +13,21 @@ class Railtie < Rails::Railtie
     initializer "coverband.configure" do |app|
       begin
         app.middleware.use Coverband::BackgroundMiddleware
+      rescue Redis::CannotConnectError => error
+        Coverband.configuration.logger.info "Redis is not available (#{error}), Coverband not configured"
+        Coverband.configuration.logger.info "If this is a setup task like assets:precompile feel free to ignore"
+      end
+    end
 
+    config.after_initialize do
+      unless Coverband.tasks_to_ignore?
+        Coverband.configure
+        Coverband.eager_loading_coverage!
+        Coverband.report_coverage
+        Coverband.runtime_coverage!
+      end
+
+      begin
         if Coverband.configuration.track_views
           COVERBAND_VIEW_TRACKER = if Coverband.coverband_service?
             Coverband::Collectors::ViewTrackerService.new
@@ -33,15 +47,6 @@ class Railtie < Rails::Railtie
       end
     end
 
-    config.after_initialize do
-      unless Coverband.tasks_to_ignore?
-        Coverband.configure
-        Coverband.eager_loading_coverage!
-        Coverband.report_coverage
-        Coverband.runtime_coverage!
-      end
-    end
-
     config.before_configuration do
       unless ENV["COVERBAND_DISABLE_AUTO_START"]
         begin

diff --git a/lib/coverband/version.rb b/lib/coverband/version.rb
@@ -5,5 +5,5 @@
 # use format '4.2.1.rc.1' ~> 4.2.1.rc to prerelease versions like v4.2.1.rc.2 and v4.2.1.rc.3
 ###
 module Coverband
-  VERSION = "5.0.0"
+  VERSION = "5.0.1.rc.1"
 end