Fixed a bug when handling non-cached range responses that aren't honored by the server. #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server responds with with an HTTP 200 (not 206), and the response has not yet been cached.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my use case: I'm playing music against a server that is unable to satisfy range requests. Instead, it returns an HTTP 200 and the full body. At this point, if the response is not in the cache, AndroidVideoCache ignores the offset and starts returning data from the beginning of the stream.
I realize this pull request may not be accepted because:
At any rate, I wanted you to be aware of the issue with a potential fix.