fix(parse): duplicates & ordering handling

Automatically de-duplicate and sort lists of values.
danielrbradley · Nov 8, 2020 · 616d4d5 · 616d4d5
1 parent 0b7868c
commit 616d4d5
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/parse.ts b/parse.ts
@@ -103,7 +103,9 @@ function parseField(input: string, field: Field): number[] | undefined {
     return range;
   }
 
-  return input.split(",").map(parseValue);
+  return Array.from(new Set(input.split(",").map(parseValue))).sort(
+    (a, b) => a - b
+  );
 }
 
 /**

diff --git a/tests/parse.test.ts b/tests/parse.test.ts
@@ -222,3 +222,15 @@ test("too few fields", () => {
     expect(error.message).toBe("Too few fields");
   }
 });
+
+test("de-duplicates list items", () => {
+  expect(parse("1,2,2,3 * * * *")).toEqual(
+    schedule([0], [1, 2, 3], u, u, u, u, u)
+  );
+});
+
+test("orders list items", () => {
+  expect(parse("1,3,2 * * * *")).toEqual(
+    schedule([0], [1, 2, 3], u, u, u, u, u)
+  );
+});