Drain stdout pipe while command is running #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@f-meloni Could you review this when you have a chance? |
f-meloni
reviewed
Jul 19, 2024
|
|
||
| let data = pipe.fileHandleForReading.readDataToEndOfFile() | ||
|
|
||
| task.waitUntilExit() |
There was a problem hiding this comment.
Would you still receive all the text output coming from the executed shell command after this change?
Given we are reading before the task ends
There was a problem hiding this comment.
We're calling readDataToEndOfFile() so we'll get the entire output of the command from the pipe before continuing to task.waitUntilExit(), which I assume will basically immediately complete at that point.
There was a problem hiding this comment.
@f-meloni does that seem correct?
f-meloni
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the commands we called as part of a Danger plugin ended up generating more output that the
Pipe's buffer could hold. This resulted in Danger locking up and blocking CI.This change moves reading from stdin to before the task has exited so that the
Pipedoes not get too full.You can test this change will the following code:
I thought about adding a test, but if the test were to ever go wrong it would lock up CI instead of failing