Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with correct advise for using the docker image in GHA #284

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

r0adkll
Copy link
Contributor

@r0adkll r0adkll commented Aug 24, 2024

The current advice for using the docker image, post v1.3.0, is incorrect for GitHub actions as it will error saying you can't use uses and run in the same step.

Instead you must setup the image as a container: on the job and then execute the runs in a step

You can see an example of this working on my PR here: r0adkll/kimchi#11

Fixing docker image advise to work with GHA syntax
Copy link
Member

@f-meloni f-meloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@f-meloni f-meloni merged commit b860365 into danger:master Aug 26, 2024
1 of 3 checks passed
@r0adkll r0adkll deleted the patch-1 branch August 26, 2024 11:50
@Roha911
Copy link

Roha911 commented Aug 29, 2024

Hot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants