Working with two-way authentication in custom Gitlab server

[skyway777]

Before this PR, DangerJS was supporting only NODE_EXTRA_CA_CERTS env-variable to set CA certificates.

In my case, I need to use also my SSL Key and my SSL Certificate to connect to Gitlab Api.

When reading node-gitlab docs https://github.com/jdalrymple/node-gitlab I've found only way to do this as using custom requester (requester prop in options)

So, I've made my own KyRequestor realization with supporting of GITLAB_SSL_KEY and GITLAB_SSL_CERT env-variables.

[skyway777]

Maybe there is better way to do it?

[orta]

I'm worried that we have both gitlab 10, as we have gitlab locked to v6 in the app - have you tried updating gitlab to v10 and seeing if that can fix it in general?

[skyway777]

At first, I've tried to use just node script without dangerjs with last gitlab as dependency.
This problem was reproduced.

Gitlab have an option to fix it - not very handy but working - send custom requester as parameter.
I made the fix with extra options
actually, this function in my code fixes my problem:

function buildAgent() {
    const { GITLAB_SSL_KEY, GITLAB_SSL_CERT } = process.env;

    if (GITLAB_SSL_KEY || GITLAB_SSL_CERT) {
        const key = readKey(GITLAB_SSL_KEY);
        const cert = readKey(GITLAB_SSL_CERT);

        return new https.Agent({
            key,
            cert,
        })
    }
    return;
}

If it would be better for this PR, I can downgrade some dependencies in my project.

Or, maybe, would be better to extend Dangerjs API to allow sending extra platform-specific options (github, bitbucket etc.) in dangerfile script? Like requester in gitlab https://github.com/jdalrymple/node-gitlab
It would allows me do not fork danger-js only to use it in my case.

[orta]

It might be worth giving this another shot now that #903 is in

[DangerCI]

	Warnings
⚠️	Could not get info from npm on custom-node-gitlab-requester

New dependencies added: custom-node-gitlab-requester.

Generated by 🚫 dangerJS against 5a1a73d

[ludakhris]

I'm curious whats up with this PR, I'm having a similar issue it seems like with a gitlab self hosted instance that has two way auth.

[skyway777]

@ludakhris I cannot check if it does work now, since I don't have access to the GitLab instance for which I've created this PR anymore. But if you need this, you can build my fork of DangerJS. It depends on my custom custom-node-gitlab-requester, which also required building.