Update GitHubAPI.getPullRequestComments #1468
Closed
+64
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfbustam
changed the title
kfbustam
commented
Dec 9, 2024
| @@ -113,13 +113,24 @@ new file mode 0 | |||
|
|
|||
| it("getDangerCommentIDs ignores comments not marked as generated", async () => { | |||
| api.getAllOfResource = await requestWithFixturedJSON("github_inline_comments_with_danger.json") | |||
| api.getUserID = () => new Promise<number>((r) => r(20229914)) | |||
| api.fetch = jest.fn().mockReturnValue({ ok: true }) | |||
There was a problem hiding this comment.
This was failing because it was making an API call (i.e., not mocked) which isn't allowed so I just included the fix in this PR 😅
kfbustam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Context: the runner process remains active during the job execution. Memoizing the data will improve performance by avoiding redundant API calls and can help you stay within GitHub's rate limits.)
it("getDangerCommentIDs ignores comments not marked as generated")it("getPullRequestComment gets only comments for given Pull Request")Test Plan
https://github.com/danger/danger-js/actions/runs/12228145418/job/34105926888?pr=1468