Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use proper env values for Bitbucket Cloud Access Token #1398

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

shitamori1272
Copy link
Contributor

Thanks to #1365, BitBucket Cloud Access Token has been supported with env DANGER_BITBUCKETCLOUD_REPO_ACCESSTOKEN.

However, this feature doesn't work currently because of the following issues.

1. Some logics uses the wrong env name DANGER_BITBUCKETCLOUD_REPOSITORY_ACCESSTOKEN.

Because of this issue, need to set both DANGER_BITBUCKETCLOUD_REPO_ACCESSTOKEN and DANGER_BITBUCKETCLOUD_REPOSITORY_ACCESSTOKEN to use this feature.
To fix this, changed the env name in the code.

2. Fails to fetch account UUID due to permission limitation.

According to https://support.atlassian.com/bitbucket-cloud/docs/repository-access-token-permissions/, Bitbucket Repository Access Token doesn't have permission to access account information which needs to fetch account UUID.
And this issue causes the following error.

Request failed [401]: https://api.bitbucket.org/2.0/user. Attempting retry.
Retry 1 of 3.
Request failed [401]: https://api.bitbucket.org/2.0/user. Attempting retry.
Retry 2 of 3.
Request failed [401]: https://api.bitbucket.org/2.0/user. Attempting retry.
Retry 3 of 3.
Request failed [401]: https://api.bitbucket.org/2.0/user
Response: {
  "type": "error",
  "error": {
    "message": "Token is invalid or not supported for this endpoint."
  }
}
Error:  Error: 401 - Unauthorized (Have you allowed permission 'account' for this credential?)

To avoid this error, allowed to use DANGER_BITBUCKETCLOUD_UUID env with Access Token.

Copy link
Member

@fbartho fbartho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, this was a clear typo in the original PR. I have no objections to this change.

@orta
Copy link
Member

orta commented Aug 8, 2023

Agree 👍🏻 - thanks

@orta orta merged commit eb1d4f9 into danger:main Aug 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants