feat: add shareable tsconfig support #1397
Open
+18
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-chan
force-pushed
the
feature/add-shareable-tsconfig-support
branch
from
7fda278
to
2bc2c09
Compare
fbartho
requested changes
Sep 10, 2023
| @@ -126,7 +126,7 @@ export const typescriptify = (content: string, dir: string): string => { | |||
| let compilerOptions: any | |||
| const tsConfigPath = lookupTSConfig(dir) | |||
| if (tsConfigPath) { | |||
| compilerOptions = JSON5.parse(fs.readFileSync(tsConfigPath, "utf8")) | |||
| compilerOptions = parseTsconfig(tsConfigPath) | |||
There was a problem hiding this comment.
This project already depends on TypeScript (see line 123), so it’s not helpful for us to pull in a 3rd-party package whose purpose is to parseTsconfig without a dependency on TypeScript!
Instead, I’d accept a PR that usests.parseConfig or a similar API that supports extends from the official dependency — that we’re already pulling in.
|
This PR looks like it’s a duplicate to #1313 — and that one has tests and an approach that better matches my feedback above. Not sure why that one stalled out though! So you might be able to pick up from where they started, or at least use it as a hint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used get-tsconfig to support tsconfig
extendsproperty.Fix #1283