-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support using the Danger shared GitHub App for OSS repos to work around the forks issue #1126
base: main
Are you sure you want to change the base?
Conversation
…nd the forks issue
OK, confirmed that this isn't reasonably possible as it is. The access to post a comment to the PR requires write access to any PR, and no-one should accept that as a reasonable trade-off for some setup convenience. Perhaps using Checks is OK, but I've found every time I've used that system to be underwhelming. |
My key argument against checks is that you lose the middle ground: danger gives message / warn / fail - but you can only really use fail in a check because all feedback is hidden from you until you click though to the checks page. You'd only click if you were blocked. |
Summary: this idea generally works for most of the route
|
Took a walk on this Removing configThe only way this could realistically work is by making some sort of web service, which I'm really not super wild on. The web service could link a repo/org to installation ID (maybe as a GH repo) which danger can look up at runtime. That would eliminate the need for Not using checks
|
|
RE: #1125
Goal: How can we simplify install instructions to as little as possible