Skip to content

Renamed points attribute in Points class to points_list #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
natejly wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Renamed points attribute in Points class to points_list #1548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plantcv/plantcv/classes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ def __init__(self, img, figsize=(12, 6)):
self.fig, self.ax = plt.subplots(1, 1, figsize=figsize)
self.ax.imshow(cv2.cvtColor(img, cv2.COLOR_BGR2RGB))

self.points = []
self.points_list = []
self.events = []

self.fig.canvas.mpl_connect('button_press_event', self.onclick)
Expand All @@ -381,12 +381,12 @@ def onclick(self, event):
if event.button == 1:

self.ax.plot(event.xdata, event.ydata, 'x', c='red')
self.points.append((floor(event.xdata), floor(event.ydata)))
self.points_list.append((floor(event.xdata), floor(event.ydata)))

else:
idx_remove, _ = _find_closest_pt((event.xdata, event.ydata), self.points)
idx_remove, _ = _find_closest_pt((event.xdata, event.ydata), self.points_list)
# remove the closest point to the user right clicked one
self.points.pop(idx_remove)
self.points_list.pop(idx_remove)
self.ax.lines[idx_remove].remove()
self.fig.canvas.draw()

Expand Down
2 changes: 1 addition & 1 deletion tests/plantcv/annotate/test_points.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,4 @@ def test_points_interactive(annotate_test_data):
e5.xdata, e5.ydata = (301, 200)
drawer_rgb.onclick(e5)

assert drawer_rgb.points[0] == point1
assert drawer_rgb.points_list[0] == point1