Skip to content

Conversation

@natejly
Copy link
Collaborator

@natejly natejly commented May 16, 2024

Changed "filter" to "mask_filter" to avoid overloading Python's default "filter" function by deep source suggestion

All existing code using the "filter" function would have to be changed, which could cause issues, so not sure if this change should be merged

@natejly natejly added help wanted Request help cleanup Code quality updates labels May 16, 2024
@deepsource-io
Copy link

deepsource-io bot commented May 16, 2024

Here's the code health analysis summary for commits 989cf90..9bea876. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython❌ Failure
❗ 7 occurences introduced
🎯 3 occurences resolved
View Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@natejly natejly self-assigned this May 16, 2024
@nfahlgren nfahlgren added work in progress Mark work in progress and removed help wanted Request help ready to review labels Jul 4, 2024
@nfahlgren nfahlgren added this to the PlantCV v5.0 milestone Jul 4, 2024
@nfahlgren nfahlgren added breaking and removed work in progress Mark work in progress labels Jul 4, 2024
@HaleySchuhl HaleySchuhl changed the base branch from main to v5.0 September 15, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking cleanup Code quality updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants