Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] updating life cycle of dandiset #275

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

djarecka
Copy link
Member

  • creating test for public dandiset that simulate the life cycle of dandiset and doi updates. Not sure if we should always run the test, so for now I added skip;
  • updates to to_datacite function, so it can also work for draft

djarecka and others added 2 commits January 18, 2025 19:39
…i updates (not sure if we should always run the etst, so for now I added skip); updates to to_datacite function
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 18.66667% with 61 lines in your changes missing coverage. Please review.

Project coverage is 89.33%. Comparing base (395bc5b) to head (2601cec).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
dandischema/datacite/tests/test_datacite.py 9.09% 60 Missing ⚠️
dandischema/datacite/__init__.py 88.88% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (395bc5b) and HEAD (2601cec). Click for more details.

HEAD has 580 uploads less than BASE
Flag BASE (395bc5b) HEAD (2601cec)
unittests 604 24
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
- Coverage   97.54%   89.33%   -8.22%     
==========================================
  Files          16       16              
  Lines        1753     1819      +66     
==========================================
- Hits         1710     1625      -85     
- Misses         43      194     +151     
Flag Coverage Δ
unittests 89.33% <18.66%> (-8.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant