Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "version" to datacite record and bundle datacite json serializations #260

Merged
merged 6 commits into from
Nov 12, 2024

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Nov 4, 2024

folded in a typo fix

partially addresses

This PR also bundles (all known versions) datacite json schemas.

@yarikoptic yarikoptic added the patch Increment the patch version when merged label Nov 4, 2024
@yarikoptic yarikoptic requested a review from djarecka November 4, 2024 14:22
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.59%. Comparing base (d3cc4b4) to head (a9c909f).
Report is 15 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #260   +/-   ##
=======================================
  Coverage   97.58%   97.59%           
=======================================
  Files          16       16           
  Lines        1739     1745    +6     
=======================================
+ Hits         1697     1703    +6     
  Misses         42       42           
Flag Coverage Δ
unittests 97.59% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member Author

all tests are failing with similar

E   requests.exceptions.ProxyError: HTTPSConnectionPool(host='raw.githubusercontent.com', port=443): Max retries exceeded with url: /datacite/schema/732cc7ef29f4cad4d6adfac83544133cd57a2e5e/source/json/kernel-4.3/datacite_4.3_schema.json (Caused by ProxyError('Unable to connect to proxy', NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f87bab74170>: Failed to establish a new connection: [Errno 111] Connection refused')))

I think it might be worth just shipping copies of desired verion(s) of datacite serializations right in here, in particular since we are referencing a specific to commit version.

@yarikoptic yarikoptic changed the title Add "version" to datacite record Add "version" to datacite record and bundle datacite json serializations Nov 4, 2024
@yarikoptic yarikoptic added minor Increment the minor version when merged and removed patch Increment the patch version when merged labels Nov 4, 2024
@yarikoptic
Copy link
Member Author

dandi-cli versions failing to install with

ERROR: Package 'dandi' requires a different Python: 3.8.18 not in '>=3.9'

since here we have not yet dropped 3.8 and in dandi-cli already did...

@djarecka
Copy link
Member

djarecka commented Nov 4, 2024

i'm wondering if we really want to keep all the version from these repositories, or decide on one that we want to match. Or perhaps we want to create our own?

@yarikoptic
Copy link
Member Author

we had to do diff archaeological expedition so I thought to accumulate them all in one common space. They are relatively lightweight so I saw no reservation from keeping them all.

❯ du -sck dandischema/datacite/schema/*
16	dandischema/datacite/schema/datacite-4.3-17-gaa5db56.json
20	dandischema/datacite/schema/datacite-4.3-72-g732cc7e.json
20	dandischema/datacite/schema/inveniosoftware-4.3-66-g24fc2ba.json
24	dandischema/datacite/schema/inveniosoftware-4.5-81-g160250d.json
4	dandischema/datacite/schema/README.md
84	total

Moreover, with exposing version in the code we could try one or another easily and consistently across versions.

@yarikoptic
Copy link
Member Author

ok, I stated my reasoning, no further objections, let's proceed!

@yarikoptic yarikoptic merged commit 9d068b9 into master Nov 12, 2024
64 checks passed
@yarikoptic yarikoptic deleted the enh-version branch November 12, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants