Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore some type-checking errors under Python 3.13 #1539

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Ignore some type-checking errors under Python 3.13 #1539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion dandi/dandiarchive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,10 @@ def is_under_download_path(self, path: str) -> bool:


@dataclass
class BaseAssetIDURL(SingleAssetURL):
# The below `type: ignore[override]` prevents mypy under Python 3.13+ from
# complaining about problems caused by overriding the types of `dandiset_id`
# and `version_id` from what they are in ParsedDandiURL.
class BaseAssetIDURL(SingleAssetURL): # type: ignore[override]
"""
Parsed from a URL that refers to an asset by ID and does not include the
Dandiset ID
Expand Down
Loading