Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PrivateAttr usage #1538

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Fix PrivateAttr usage #1538

merged 1 commit into from
Nov 25, 2024

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Nov 25, 2024

Closes #1537.

@jwodder jwodder added the patch Increment the patch version when merged label Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.54%. Comparing base (3940aa2) to head (39a0e20).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1538      +/-   ##
==========================================
+ Coverage   88.45%   88.54%   +0.08%     
==========================================
  Files          78       78              
  Lines       10691    10691              
==========================================
+ Hits         9457     9466       +9     
+ Misses       1234     1225       -9     
Flag Coverage Δ
unittests 88.54% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic yarikoptic merged commit ff49fd1 into master Nov 25, 2024
23 of 25 checks passed
@yarikoptic yarikoptic deleted the gh-1537 branch November 25, 2024 20:09
Copy link

🚀 PR was released in 0.65.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typing check started to fail: error: No overload variant of "PrivateAttr" matches argument type "None"
2 participants