Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance pynwb validation parsing to report the path within the file, fix pynwb typo #1513

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Oct 4, 2024

re: con/validation#1 (comment)

PyNWB reports a list of HDMF validator Error objects.

  • Enhance pynwb validator output to report the path within the file and separate the reason (message) from the rest of the error.
  • Fix typo "pywnb" -> "pynwb"

@rly
Copy link
Contributor Author

rly commented Oct 4, 2024

Note that NWB inspector runs the pynwb validator and parses its output, so if you run that first, then running the pynwb validator is unnecessary.

@kabilar kabilar requested a review from jwodder October 5, 2024 13:36
@yarikoptic yarikoptic added the patch Increment the patch version when merged label Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.56%. Comparing base (61e28e0) to head (2046eb8).
Report is 30 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1513      +/-   ##
==========================================
- Coverage   88.58%   88.56%   -0.02%     
==========================================
  Files          78       78              
  Lines       10589    10589              
==========================================
- Hits         9380     9378       -2     
- Misses       1209     1211       +2     
Flag Coverage Δ
unittests 88.56% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic yarikoptic changed the title Enhance pynwb validation parsing, fix pynwb typo Enhance pynwb validation parsing to report the path within the file, fix pynwb typo Oct 14, 2024
@yarikoptic yarikoptic merged commit 6aa414c into dandi:master Oct 14, 2024
25 of 26 checks passed
@rly rly deleted the enhance_pynwb_validation branch October 15, 2024 01:29
Copy link

🚀 PR was released in 0.64.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants