Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --preserve-tree option to dandi download #1467

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Add --preserve-tree option to dandi download #1467

merged 1 commit into from
Jul 24, 2024

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jul 23, 2024

Closes #1460.

@jwodder jwodder added minor Increment the minor version when merged cmd-download labels Jul 23, 2024
@jwodder jwodder requested a review from yarikoptic July 23, 2024 18:33
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.60%. Comparing base (c0b64d5) to head (c583a89).
Report is 53 commits behind head on master.

Files with missing lines Patch % Lines
dandi/dandiarchive.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1467      +/-   ##
==========================================
+ Coverage   88.55%   88.60%   +0.05%     
==========================================
  Files          77       77              
  Lines       10535    10556      +21     
==========================================
+ Hits         9329     9353      +24     
+ Misses       1206     1203       -3     
Flag Coverage Δ
unittests 88.60% <97.05%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kabilar
Copy link
Member

kabilar commented Jul 24, 2024

Thank you @jwodder. This feature will be very helpful.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yarikoptic yarikoptic merged commit 2308f95 into master Jul 24, 2024
28 checks passed
@yarikoptic yarikoptic deleted the gh-1460 branch July 24, 2024 19:07
Copy link

github-actions bot commented Aug 8, 2024

🚀 PR was released in 0.63.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd-download minor Increment the minor version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

download: add --keep-leading-path|-k or some mode for --download
3 participants