Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assorted Docker Compose improvements #1465

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Assorted Docker Compose improvements #1465

merged 3 commits into from
Jul 23, 2024

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jul 23, 2024 •
edited
Loading

Closes #1168.

@jwodder jwodder added the tests Add or improve existing tests label Jul 23, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.58%. Comparing base (c893aa0) to head (76e7d14).
Report is 57 commits behind head on master.

Files with missing lines Patch % Lines
dandi/tests/fixtures.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1465      +/-   ##
==========================================
+ Coverage   88.49%   88.58%   +0.08%     
==========================================
  Files          77       77              
  Lines       10535    10535              
==========================================
+ Hits         9323     9332       +9     
+ Misses       1212     1203       -9
Flag Coverage Δ
unittests 88.58% <66.66%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwodder jwodder marked this pull request as draft July 23, 2024 13:11
@jwodder jwodder changed the title Remove duplicate DJANGO_DANDI_DEV_EMAIL key in docker-compose.yml Assorted Docker Compose improvements Jul 23, 2024
@jwodder jwodder marked this pull request as ready for review July 23, 2024 15:26
@jwodder jwodder merged commit c0b64d5 into master Jul 23, 2024
27 of 28 checks passed
@jwodder jwodder deleted the fix-compose branch July 23, 2024 15:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

🚀 PR was released in 0.63.0 🚀

@TheChymera TheChymera mentioned this pull request Aug 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released tests Add or improve existing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jwodder