Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set 30-second connect & read timeout when downloading files #1369

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Nov 28, 2023

Closes #1366.

@jwodder jwodder added the patch Increment the patch version when merged label Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (eea1411) 88.72% compared to head (e538d46) 88.79%.

Files Patch % Lines
dandi/download.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1369      +/-   ##
==========================================
+ Coverage   88.72%   88.79%   +0.07%     
==========================================
  Files          77       77              
  Lines       10424    10427       +3     
==========================================
+ Hits         9249     9259      +10     
+ Misses       1175     1168       -7     
Flag Coverage Δ
unittests 88.79% <50.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member

Thank you!

@yarikoptic yarikoptic merged commit 036df85 into master Nov 29, 2023
27 of 28 checks passed
@yarikoptic yarikoptic deleted the gh-1366 branch November 29, 2023 15:51
Copy link

🚀 PR was released in 0.58.2 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloads hang indefinitely if connection interrupted from lack of timeout
2 participants