Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move imports in functions to top level or annotate why they can't be moved #1368

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Nov 28, 2023

No description provided.

@jwodder jwodder added internal Changes only affect the internal API code quality Nonfunctional improvements to the codebase labels Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0971d02) 88.64% compared to head (5ae3731) 88.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1368      +/-   ##
==========================================
+ Coverage   88.64%   88.82%   +0.18%     
==========================================
  Files          77       77              
  Lines       10434    10424      -10     
==========================================
+ Hits         9249     9259      +10     
+ Misses       1185     1165      -20     
Flag Coverage Δ
unittests 88.82% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dandi/metadata/nwb.py Dismissed Show dismissed Hide dismissed
@jwodder jwodder marked this pull request as ready for review November 28, 2023 16:34
@yarikoptic yarikoptic merged commit 6f18a4b into master Nov 28, 2023
28 checks passed
@yarikoptic yarikoptic deleted the move-imports branch November 28, 2023 19:06
Copy link

🚀 PR was released in 0.58.2 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Nonfunctional improvements to the codebase internal Changes only affect the internal API released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants