Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _order_ attribute from Severity enum #1348

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Remove _order_ attribute from Severity enum #1348

merged 1 commit into from
Nov 9, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Nov 8, 2023

That attribute only has a purpose when supporting both Python 2 and Python 3, which we are not doing. CC @TheChymera.

@jwodder jwodder added internal Changes only affect the internal API code quality Nonfunctional improvements to the codebase labels Nov 8, 2023
Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge when CI finishes up

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9335182) 89.04% compared to head (028a6f1) 89.04%.
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1348      +/-   ##
==========================================
- Coverage   89.04%   89.04%   -0.01%     
==========================================
  Files          76       76              
  Lines       10243    10242       -1     
==========================================
- Hits         9121     9120       -1     
  Misses       1122     1122              
Flag Coverage Δ
unittests 89.04% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dandi/validate_types.py 87.80% <ø> (-0.30%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwodder
Copy link
Member Author

jwodder commented Nov 8, 2023

@yarikoptic CI is currently quiet.

@yarikoptic yarikoptic merged commit 27e418d into master Nov 9, 2023
25 checks passed
@yarikoptic yarikoptic deleted the no-order branch November 9, 2023 16:42
@yarikoptic
Copy link
Member

@yarikoptic CI is currently quiet.

feel welcome to merge such PRs yourself, especially if I "blessed" them already ;-)

Copy link

🚀 PR was released in 0.58.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Nonfunctional improvements to the codebase internal Changes only affect the internal API released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants