Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .h264 as a supported video file extension #1329

Closed
wants to merge 1 commit into from
Closed

Add .h264 as a supported video file extension #1329

wants to merge 1 commit into from

Conversation

rly
Copy link
Contributor

@rly rly commented Sep 12, 2023

Fix #1328

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8a06a6e) 88.85% compared to head (b4fab27) 88.85%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1329   +/-   ##
=======================================
  Coverage   88.85%   88.85%           
=======================================
  Files          76       76           
  Lines       10200    10200           
=======================================
  Hits         9063     9063           
  Misses       1137     1137           
Flag Coverage Δ
unittests 88.85% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
dandi/consts.py 98.11% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member

Sorry @rly for taking so long to get back to this one. In the light of @satra 's feedback and your follow up on #1328 (comment) - I will just close it for now. If you think we should resurrect -- let me know. Personally -- I think I never saw/used .h264 file, and indeed conversion into a more common/supported container might be of benefit to the end users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support upload of h264 video files
2 participants