-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .nwb to known Zarr suffixes; add tests for NWB Zarr backend #1312
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1312 +/- ##
===========================================
- Coverage 88.51% 67.93% -20.58%
===========================================
Files 77 77
Lines 10492 10480 -12
===========================================
- Hits 9287 7120 -2167
- Misses 1205 3360 +2155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The current CI error TypeError: Can't instantiate abstract class NWBZarrIO with abstract method can_read has a known cause and will likely need to await the upcoming release of |
@yarikoptic Trying the main branch (not this one) with
Worth mentioning it began upload and proceeded find until 99% done when the error happened |
eh -- I spent some time trying to see smth in the logs
today
or if you retry again -- I might spot smth in the fresh dumps for heroku which I should be getting now. |
FWIW, in
so we do not install development hdmf as well. Do you think we should? |
Inspired by #1312 and ongoing work for Zarr based backend for NWB.
I just tried again (from the save environment) and did not get the previous error Asset is now visible: https://gui-staging.dandiarchive.org/dandiset/204919/draft/files?location=test_read_nwbfile |
BTW the 'environment' I'm using right now is just the default/base on the DANDI Hub |
trying in #1320 and it leads to an error (posted there)
well, would need 1 more fresh .nwb.zarr I guess ;-) |
Inspired by #1312 and ongoing work for Zarr based backend for NWB.
fix #1310
This seems to have worked fine for me on a local upload attempt to staging (validation had to be suppressed until we get NeurodataWithoutBorders/nwbinspector#388 and the integration follow-up through)
At least getting the seeds of this PR started