Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude special dotfiles from Zarrs #1147

Merged
merged 8 commits into from
Oct 31, 2022
Merged

Exclude special dotfiles from Zarrs #1147

merged 8 commits into from
Oct 31, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Oct 28, 2022

Closes #1146.

To do:

  • Exclude dotfiles when uploading a Zarr
  • Exclude dotfiles when downloading a Zarr
  • Exclude dotfiles when determining whether a Zarr is empty
  • Exclude dotfiles when determining whether a Zarr has exceeded the maximum depth
  • Investigate expanding the exclusion to special dotfiles at all levels, rather than just at the root

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 88.14% // Head: 88.28% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (0064071) compared to base (48a222f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1147      +/-   ##
==========================================
+ Coverage   88.14%   88.28%   +0.14%     
==========================================
  Files          73       73              
  Lines        8727     8800      +73     
==========================================
+ Hits         7692     7769      +77     
+ Misses       1035     1031       -4     
Flag Coverage Δ
unittests 88.28% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/cli/tests/test_digest.py 100.00% <100.00%> (ø)
dandi/download.py 88.04% <100.00%> (+0.04%) ⬆️
dandi/files/_private.py 98.03% <100.00%> (+2.20%) ⬆️
dandi/files/zarr.py 88.03% <100.00%> (+1.17%) ⬆️
dandi/support/digests.py 100.00% <100.00%> (ø)
dandi/support/threaded_walk.py 93.10% <100.00%> (+0.24%) ⬆️
dandi/tests/test_files.py 100.00% <100.00%> (ø)
dandi/utils.py 82.31% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jwodder jwodder changed the title Exclude special dotfiles from the root of Zarrs Exclude special dotfiles from Zarrs Oct 28, 2022
@jwodder jwodder marked this pull request as ready for review October 28, 2022 15:43
@yarikoptic
Copy link
Member

Thank you @jwodder ! I am not 100% sure about making it unconditionally yet, but for now should be good to go.

@yarikoptic yarikoptic merged commit b23fee4 into master Oct 31, 2022
@yarikoptic yarikoptic deleted the gh-1146 branch October 31, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd-digest cmd-download cmd-upload minor Increment the minor version when merged zarr
Projects
None yet
2 participants