Skip to content

Commit

Permalink
Merge pull request #1512 from dandi/rf-test-xfails
Browse files Browse the repository at this point in the history
Add xfail marks for some tests: test_nwb2asset_remote_asset, test_reextract_metadata, test_IteratorWithAggregation
  • Loading branch information
yarikoptic authored Oct 2, 2024
2 parents 1c89d42 + 01980d5 commit 61e28e0
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions dandi/cli/tests/test_service_scripts.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@
DATA_DIR = Path(__file__).with_name("data")


@pytest.mark.xfail(
"nfsmount" in os.environ.get("TMPDIR", ""),
reason="https://github.com/dandi/dandi-cli/issues/1507",
)
def test_reextract_metadata(
monkeypatch: pytest.MonkeyPatch, nwb_dandiset: SampleDandiset
) -> None:
Expand Down
3 changes: 3 additions & 0 deletions dandi/support/tests/test_iterators.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

import pytest

from dandi.utils import on_windows

from ..iterators import IteratorWithAggregation


Expand Down Expand Up @@ -31,6 +33,7 @@ def sleeping_range(n, secs=0.01, thr=None):
raise ValueError(i)


@pytest.mark.xfail(on_windows, reason="https://github.com/dandi/dandi-cli/issues/1510")
def test_IteratorWithAggregation():
def sumup(v, t=0):
return v + t
Expand Down
1 change: 1 addition & 0 deletions dandi/tests/test_metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -883,6 +883,7 @@ def test_nwb2asset(simple2_nwb: Path) -> None:
)


@pytest.mark.xfail(reason="https://github.com/dandi/dandi-cli/issues/1450")
def test_nwb2asset_remote_asset(nwb_dandiset: SampleDandiset) -> None:
pytest.importorskip("fsspec")
asset = nwb_dandiset.dandiset.get_asset_by_path("sub-mouse001/sub-mouse001.nwb")
Expand Down

0 comments on commit 61e28e0

Please sign in to comment.