Set assets to pending during unembargo #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnesbitt
force-pushed
the
set-assets-pending-during-unembargo
branch
from
2bb83e4 to
914a1d5
Compare
jjnesbitt
force-pushed
the
set-assets-pending-during-unembargo
branch
from
914a1d5 to
413c4d8
Compare
|
@yarikoptic @jwodder It seems the integration tests are failing, although I can't really discern why, as there's so much log output. It's just the |
|
@jjnesbitt It looks like the tests are failing because they expect Dandiset "citation" fields to say "DANDI archive" instead of "DANDI Archive". |
Hmm okay, seems like it's due to #2114 being merged. Could those tests be updated then? |
|
Much appreciated! |
mvandenburgh
approved these changes
Dec 23, 2024
jjnesbitt
added
patch
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the effects of #2116. Currently, without this change, every asset of a previously unembargoed dandiset can be left with the validation error
An embargo end date is required for NIH awards to be in compliance with NIH resource sharing policy.. Now, when a dandiset is unembargoed, all assets will be set toPENDINGstatus, so that their metadata can be re-validated.