DLP: Add "Protocols" card #2103
Conversation
There was a problem hiding this comment.
My suggested changes are visible at the deploy preview for a dummy PR I opened against this branch.
As for the padding issue around the protocols card, I looked into it briefly but could not come up with anything immediately. We will need @mvandenburgh or @jjnesbitt's expertise.
Co-authored-by: Yaroslav Halchenko <[email protected]>
It seems that the issue isn't that the protocols card has this padding, but that the Contributors card does not. i.e. every card seems to have this padding except the Contributors one. See #2112 for the fix. |
|
Ah, the "Assets Summary" card has the same issue as "Contributors". I'll update my PR. |
The `MetadataCard` wraps its contents in a `v-row` and `v-col`, which adds some additional padding around the card. The "Contributors" card, however, is the only DLP card that doesn't use the `MetadataCard` component. Prior to this change, the "Contributors" card didn't use `v-row` and `v-col`, so it didn't have the same padding as the other cards.
See previous commit about `Contributors` card, this is the same issue.
FTR: here is how layout looks like -- with @mvandenburgh changes all good
NB there is those imho unnecessary horizontal margins, but that is a separate unrelated to this PR issue (filed #2113) |
|
🚀 PR was released in |
Closes #2071
There seems to be a little design gotcha -- a space from prior section which I do not know framework well enough to see where to add anything to make it not indent itself.