Resolve remaining failures in #1823#1838
Resolve remaining failures in #1823#1838yarikoptic merged 4 commits intodandi:rf-new-dandischemafrom
Conversation
The validator for the `assetsSummary` field in the `PublishedDandiset` model in dandischema 0.9.0 generates an error with a slightly different message
The validator for the `digest` field in the `PublishedAsset` model in dandischema 0.9.0 generates an error with a slightly different message than before
|
@mvandenburgh I don't have experience with Vue. Would you take a look at this PR to see if you can resolve the failures in the frontend tests? I suspect the failures in those tests are result of the changes in the JSON schema. You can locate the documentation of those changes at the top posts of dandi/dandi-schema#203 and dandi/dandi-schema#218. |
|
Great -- thank you @candleindark ! indeed only e2e tests remain affected , so let's wait for @mvandenburgh or other @dandi/archive-maintainers web-tech aware folks to chime in before merging into the original PR #1823 for an overall look/review. |
|
To minimize number of open PRs, I will progress #1823 to the state in this PR, which will probably make github to close this one. |
|
@mvandenburgh feel welcome to self-assign #1823 ;-) |
3 participants
This PR resolves the remaining failures in tests for backend in #1823 once dandi/dandi-schema#218 is merged to the master of the
dandi-schemarepo, a new version ofdandi-schemais published, and set to be used bydandi-archive.