fix(create-pages): e2e test createApi and fix method+path combos #1141
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tylersayshi
changed the title
|
|
||
| createApi({ | ||
| path: '/api/empty', | ||
| mode: 'static', |
There was a problem hiding this comment.
It's probably a doc issue, but if we use static mode, we recommend using file extension like /api/empty.txt. Otherwise, the static build will be /api/empty/index.html.
There was a problem hiding this comment.
We can enforce that with types, but I think docs are the right way to encourage that to start.
| params: | ||
| | { | ||
| path: Path; | ||
| mode: 'static'; | ||
| method: 'GET'; | ||
| handler: (req: Request) => Promise<Response>; | ||
| } | ||
| | { | ||
| path: Path; | ||
| mode: 'dynamic'; | ||
| method: Method; | ||
| handler: (req: Request) => Promise<Response>; | ||
| }, |
There was a problem hiding this comment.
Nice. We can even force file extension for path for static mode.
There was a problem hiding this comment.
yep! If we want
| @@ -227,27 +236,26 @@ export const createPages = < | |||
| [PathSpec, FunctionComponent<any>] | |||
| >(); | |||
| const apiPathMap = new Map< | |||
| string, | |||
| string, // `${method} ${path}` | |||
There was a problem hiding this comment.
Seems room for improvement, but just a nit.
There was a problem hiding this comment.
do you have any suggestions? this composite key approach feels a tiny bit tricky to use, but it solves the problem really well
There was a problem hiding this comment.
Not right away. I'll let you know if something arises.
e2e tests for createApi usage in createPages
chore: remove default main.tsx from spec (happy to revert this if we want it there for some reason)