Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflow): canary-ci again #1057

Closed
wants to merge 44 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
4497069
use steps
dai-shi Dec 10, 2024
6f79df9
install deps again
dai-shi Dec 10, 2024
d507897
wip: ci
dai-shi Dec 10, 2024
ce7936a
ternary
dai-shi Dec 10, 2024
7d77644
only run wip
dai-shi Dec 10, 2024
9216ce5
fix yaml
dai-shi Dec 10, 2024
9e39f0e
Merge branch 'main' into canary-ci-2-fix-2
dai-shi Dec 12, 2024
5f0be5c
wip: ci
dai-shi Dec 12, 2024
bfb46f0
wip
dai-shi Dec 12, 2024
c8c762b
wip 2
dai-shi Dec 12, 2024
5faa83e
wip with ci.yml
dai-shi Dec 12, 2024
c381c47
fix exp
dai-shi Dec 12, 2024
e237ee1
fix exp 2
dai-shi Dec 12, 2024
65b06df
fix exp 3
dai-shi Dec 12, 2024
2920b66
fix exp 4
dai-shi Dec 12, 2024
1487e49
fix exp 5
dai-shi Dec 12, 2024
5eb4788
wip ci
dai-shi Dec 12, 2024
3922e73
wip ci 2
dai-shi Dec 12, 2024
9e9945c
testing ci 1
dai-shi Dec 12, 2024
a629bd8
testing ci 2
dai-shi Dec 12, 2024
28ed0ef
testing ci 3
dai-shi Dec 12, 2024
30fb381
wip: skip create waku spec
dai-shi Dec 12, 2024
9f0a736
Revert "wip: skip create waku spec"
dai-shi Dec 12, 2024
d53e0fc
testing ci 4
dai-shi Dec 12, 2024
dc5c94e
testing ci 5
dai-shi Dec 12, 2024
7f8ace9
testing ci 6
dai-shi Dec 12, 2024
02f2f3b
testing ci 7
dai-shi Dec 12, 2024
e321720
testing ci 8
dai-shi Dec 12, 2024
9646cf9
Revert "testing ci 8"
dai-shi Dec 12, 2024
3ca3bc2
remove find
dai-shi Dec 12, 2024
cde9f94
cli do not install
dai-shi Dec 12, 2024
1e2ab33
cli do not install 2
dai-shi Dec 12, 2024
b193dd7
cli testing
dai-shi Dec 12, 2024
71b7448
revert changes
dai-shi Dec 12, 2024
4665350
wip ci again
dai-shi Dec 12, 2024
08df7ca
wip ci again 2
dai-shi Dec 12, 2024
b32db9b
wip ci again 3
dai-shi Dec 12, 2024
c2d048a
Merge branch 'main' into canary-ci-2-fix-2
dai-shi Dec 13, 2024
4bb16e5
react_version input
dai-shi Dec 13, 2024
ac1050d
starting experiment with ci-wip
dai-shi Dec 13, 2024
4ddfa5e
fix
dai-shi Dec 13, 2024
6a56265
Merge branch 'main' into canary-ci-2-fix-2
dai-shi Dec 14, 2024
c12e62f
Merge branch 'main' into canary-ci-2-fix-2
dai-shi Dec 14, 2024
f6ede62
Merge branch 'main' into canary-ci-2-fix-2
dai-shi Dec 24, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/canary-ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
name: Canary CI

on:
issue_comment:
types: [created]

jobs:
canary-ci:
if: ${{ github.event.issue.pull_request && startsWith(github.event.comment.body, '/canary-ci run') }}
steps:
- uses: ./.github/workflows/ci.yml
with:
react_version: 'canary'
115 changes: 115 additions & 0 deletions .github/workflows/ci-wip.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,115 @@
name: CI-WIP

on:
pull_request:
types: [synchronize]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
test-wip:
name: WIP Test on (Node ${{ matrix.version }})
strategy:
fail-fast: false
matrix:
version: [18.17.0, 20.8.0, 22.7.0]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.version }}
cache: ''
cache-dependency-path: '**/pnpm-lock.yaml'
- run: pnpm install --frozen-lockfile
- run: |
pnpm -r update react@canary react-dom@canary react-server-dom-webpack@canary
- run: pnpm test

build-wip:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
- uses: actions/setup-node@v4
with:
node-version: 18
cache: ''
cache-dependency-path: '**/pnpm-lock.yaml'
- run: pnpm install --frozen-lockfile
- run: |
sed -i~ '/"peerDependencies"/,${s/ :".*"/: "*"/}' packages/waku/package.json
pnpm -r update react@canary react-dom@canary react-server-dom-webpack@canary
- run: pnpm run compile
- uses: actions/upload-artifact@v4
with:
name: create-waku
path: |
packages/create-waku
!packages/create-waku/node_modules
if-no-files-found: error
- uses: actions/upload-artifact@v4
with:
name: waku
path: |
packages/waku
!packages/waku/node_modules
if-no-files-found: error

e2e-wip:
name: WIP E2E on ${{ matrix.os }} (Node ${{ matrix.version }}) - (${{ matrix.shared }}/4)
needs:
- build-wip
strategy:
fail-fast: false
matrix:
shared: [1, 2, 3, 4]
shardTotal: [4]
os: [ubuntu-latest, windows-latest, macos-latest]
version: [18.17.0, 20.8.0, 22.7.0]
exclude:
- os: macos-latest
version: 18.17.0
- os: macos-latest
version: 20.8.0
- os: windows-latest
version: 18.17.0
- os: windows-latest
version: 20.8.0
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.version }}
cache: ''
cache-dependency-path: '**/pnpm-lock.yaml'
- run: pnpm install --frozen-lockfile
- uses: actions/download-artifact@v4
with:
name: create-waku
path: packages/create-waku
- uses: actions/download-artifact@v4
with:
name: waku
path: packages/waku
- name: Install Playwright
id: install-playwright
uses: ./.github/actions/playwright
- run: |
pnpm -r update react@canary react-dom@canary react-server-dom-webpack@canary
pnpm install --lockfile-only
- run: pnpm exec playwright test --shard=${{ matrix.shared }}/${{ matrix.shardTotal }}
env:
TEMP_DIR: ${{ runner.temp }}
- uses: actions/upload-artifact@v3
if: always()
with:
name: playwright-report-${{ matrix.os }}-${{ matrix.version }}-${{ matrix.shared }}
path: test-results/
retention-days: 30
if-no-files-found: ignore
25 changes: 20 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,12 @@ on:
push:
branches: [main]
pull_request:
types: [opened, synchronize]
types: [opened]
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should revert this when it works and is ready for merge.

workflow_call:
inputs:
react_version:
required: true
type: string

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand All @@ -24,9 +29,12 @@ jobs:
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.version }}
cache: 'pnpm'
cache: ${{ !inputs.react_version && 'pnpm' || '' }}
cache-dependency-path: '**/pnpm-lock.yaml'
- run: pnpm install --frozen-lockfile
- if: ${{ inputs.react_version }}
run: |
pnpm -r update react@${{ inputs.react_version }} react-dom@${{ inputs.react_version }} react-server-dom-webpack@${{ inputs.react_version }}
- run: pnpm test

build:
Expand All @@ -37,9 +45,13 @@ jobs:
- uses: actions/setup-node@v4
with:
node-version: 18
cache: 'pnpm'
cache: ${{ !inputs.react_version && 'pnpm' || '' }}
cache-dependency-path: '**/pnpm-lock.yaml'
- run: pnpm install --frozen-lockfile
- if: ${{ inputs.react_version }}
run: |
sed -i~ '/"peerDependencies"/,${s/ :".*"/: "*"/}' packages/waku/package.json
pnpm -r update react@${{ inputs.react_version }} react-dom@${{ inputs.react_version }} react-server-dom-webpack@${{ inputs.react_version }}
- run: pnpm run compile
- uses: actions/upload-artifact@v4
with:
Expand Down Expand Up @@ -76,15 +88,14 @@ jobs:
version: 18.17.0
- os: windows-latest
version: 20.8.0

runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.version }}
cache: 'pnpm'
cache: ${{ !inputs.react_version && 'pnpm' || '' }}
cache-dependency-path: '**/pnpm-lock.yaml'
- run: pnpm install --frozen-lockfile
- uses: actions/download-artifact@v4
Expand All @@ -98,6 +109,10 @@ jobs:
- name: Install Playwright
id: install-playwright
uses: ./.github/actions/playwright
- if: ${{ inputs.react_version }}
run: |
pnpm -r update react@${{ inputs.react_version }} react-dom@${{ inputs.react_version }} react-server-dom-webpack@${{ inputs.react_version }}
pnpm install --lockfile-only
- run: pnpm exec playwright test --shard=${{ matrix.shared }}/${{ matrix.shardTotal }}
env:
TEMP_DIR: ${{ runner.temp }}
Expand Down
Loading