-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(workflow): canary-ci again #1057
Closed
Closed
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
4497069
use steps
dai-shi 6f79df9
install deps again
dai-shi d507897
wip: ci
dai-shi ce7936a
ternary
dai-shi 7d77644
only run wip
dai-shi 9216ce5
fix yaml
dai-shi 9e39f0e
Merge branch 'main' into canary-ci-2-fix-2
dai-shi 5f0be5c
wip: ci
dai-shi bfb46f0
wip
dai-shi c8c762b
wip 2
dai-shi 5faa83e
wip with ci.yml
dai-shi c381c47
fix exp
dai-shi e237ee1
fix exp 2
dai-shi 65b06df
fix exp 3
dai-shi 2920b66
fix exp 4
dai-shi 1487e49
fix exp 5
dai-shi 5eb4788
wip ci
dai-shi 3922e73
wip ci 2
dai-shi 9e9945c
testing ci 1
dai-shi a629bd8
testing ci 2
dai-shi 28ed0ef
testing ci 3
dai-shi 30fb381
wip: skip create waku spec
dai-shi 9f0a736
Revert "wip: skip create waku spec"
dai-shi d53e0fc
testing ci 4
dai-shi dc5c94e
testing ci 5
dai-shi 7f8ace9
testing ci 6
dai-shi 02f2f3b
testing ci 7
dai-shi e321720
testing ci 8
dai-shi 9646cf9
Revert "testing ci 8"
dai-shi 3ca3bc2
remove find
dai-shi cde9f94
cli do not install
dai-shi 1e2ab33
cli do not install 2
dai-shi b193dd7
cli testing
dai-shi 71b7448
revert changes
dai-shi 4665350
wip ci again
dai-shi 08df7ca
wip ci again 2
dai-shi b32db9b
wip ci again 3
dai-shi c2d048a
Merge branch 'main' into canary-ci-2-fix-2
dai-shi 4bb16e5
react_version input
dai-shi ac1050d
starting experiment with ci-wip
dai-shi 4ddfa5e
fix
dai-shi 6a56265
Merge branch 'main' into canary-ci-2-fix-2
dai-shi c12e62f
Merge branch 'main' into canary-ci-2-fix-2
dai-shi f6ede62
Merge branch 'main' into canary-ci-2-fix-2
dai-shi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
name: Canary CI | ||
|
||
on: | ||
issue_comment: | ||
types: [created] | ||
|
||
jobs: | ||
canary-ci: | ||
if: ${{ github.event.issue.pull_request && startsWith(github.event.comment.body, '/canary-ci run') }} | ||
steps: | ||
- uses: ./.github/workflows/ci.yml | ||
with: | ||
react_version: 'canary' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,115 @@ | ||
name: CI-WIP | ||
|
||
on: | ||
pull_request: | ||
types: [synchronize] | ||
|
||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.ref }} | ||
cancel-in-progress: true | ||
|
||
jobs: | ||
test-wip: | ||
name: WIP Test on (Node ${{ matrix.version }}) | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
version: [18.17.0, 20.8.0, 22.7.0] | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: pnpm/action-setup@v4 | ||
- uses: actions/setup-node@v4 | ||
with: | ||
node-version: ${{ matrix.version }} | ||
cache: '' | ||
cache-dependency-path: '**/pnpm-lock.yaml' | ||
- run: pnpm install --frozen-lockfile | ||
- run: | | ||
pnpm -r update react@canary react-dom@canary react-server-dom-webpack@canary | ||
- run: pnpm test | ||
|
||
build-wip: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: pnpm/action-setup@v4 | ||
- uses: actions/setup-node@v4 | ||
with: | ||
node-version: 18 | ||
cache: '' | ||
cache-dependency-path: '**/pnpm-lock.yaml' | ||
- run: pnpm install --frozen-lockfile | ||
- run: | | ||
sed -i~ '/"peerDependencies"/,${s/ :".*"/: "*"/}' packages/waku/package.json | ||
pnpm -r update react@canary react-dom@canary react-server-dom-webpack@canary | ||
- run: pnpm run compile | ||
- uses: actions/upload-artifact@v4 | ||
with: | ||
name: create-waku | ||
path: | | ||
packages/create-waku | ||
!packages/create-waku/node_modules | ||
if-no-files-found: error | ||
- uses: actions/upload-artifact@v4 | ||
with: | ||
name: waku | ||
path: | | ||
packages/waku | ||
!packages/waku/node_modules | ||
if-no-files-found: error | ||
|
||
e2e-wip: | ||
name: WIP E2E on ${{ matrix.os }} (Node ${{ matrix.version }}) - (${{ matrix.shared }}/4) | ||
needs: | ||
- build-wip | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
shared: [1, 2, 3, 4] | ||
shardTotal: [4] | ||
os: [ubuntu-latest, windows-latest, macos-latest] | ||
version: [18.17.0, 20.8.0, 22.7.0] | ||
exclude: | ||
- os: macos-latest | ||
version: 18.17.0 | ||
- os: macos-latest | ||
version: 20.8.0 | ||
- os: windows-latest | ||
version: 18.17.0 | ||
- os: windows-latest | ||
version: 20.8.0 | ||
runs-on: ${{ matrix.os }} | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: pnpm/action-setup@v4 | ||
- uses: actions/setup-node@v4 | ||
with: | ||
node-version: ${{ matrix.version }} | ||
cache: '' | ||
cache-dependency-path: '**/pnpm-lock.yaml' | ||
- run: pnpm install --frozen-lockfile | ||
- uses: actions/download-artifact@v4 | ||
with: | ||
name: create-waku | ||
path: packages/create-waku | ||
- uses: actions/download-artifact@v4 | ||
with: | ||
name: waku | ||
path: packages/waku | ||
- name: Install Playwright | ||
id: install-playwright | ||
uses: ./.github/actions/playwright | ||
- run: | | ||
pnpm -r update react@canary react-dom@canary react-server-dom-webpack@canary | ||
pnpm install --lockfile-only | ||
- run: pnpm exec playwright test --shard=${{ matrix.shared }}/${{ matrix.shardTotal }} | ||
env: | ||
TEMP_DIR: ${{ runner.temp }} | ||
- uses: actions/upload-artifact@v3 | ||
if: always() | ||
with: | ||
name: playwright-report-${{ matrix.os }}-${{ matrix.version }}-${{ matrix.shared }} | ||
path: test-results/ | ||
retention-days: 30 | ||
if-no-files-found: ignore |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should revert this when it works and is ready for merge.