Skip to content

Commit

Permalink
fix: github workflow for canary-ci (#1153)
Browse files Browse the repository at this point in the history
#1118 seems to have some issues for comment triggers.
  • Loading branch information
dai-shi authored Jan 14, 2025
1 parent 5b3c307 commit 1083fc7
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/canary-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,12 @@ jobs:
needs: parse-version
uses: ./.github/workflows/e2e.yml
with:
react_version: ${{ needs.parse-version.outputs.react_version }}
ref: ${{ github.ref }}
react_version: ${{ needs.get-version.outputs.react_version }}

canary-ci-test:
needs: parse-version
uses: ./.github/workflows/test.yml
with:
react_version: ${{ needs.parse-version.outputs.react_version }}
ref: ${{ github.ref }}
react_version: ${{ needs.get-version.outputs.react_version }}
7 changes: 7 additions & 0 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ on:
- '.github/workflows/e2e.yml'
workflow_call:
inputs:
ref:
required: true
type: string
react_version:
required: true
type: string
Expand All @@ -30,6 +33,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
ref: ${{ inputs.ref || '' }}
- uses: pnpm/action-setup@v4
- uses: actions/setup-node@v4
with:
Expand Down Expand Up @@ -79,6 +84,8 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
with:
ref: ${{ inputs.ref || '' }}
- uses: pnpm/action-setup@v4
- uses: actions/setup-node@v4
with:
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ on:
types: [opened, synchronize]
workflow_call:
inputs:
ref:
required: true
type: string
react_version:
required: true
type: string
Expand All @@ -21,6 +24,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
ref: ${{ inputs.ref || '' }}
- uses: pnpm/action-setup@v4
- uses: actions/setup-node@v4
with:
Expand Down

0 comments on commit 1083fc7

Please sign in to comment.