-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Ability to emit sync-compatible Rust code. #6040
Open
MikaelMayer
wants to merge
19
commits into
master
Choose a base branch
from
fix-5969-sync-for-rust
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelMayer
added
the
run-integration-tests
Forces running the CI for integration tests even if the deep tests fail
label
Jan 10, 2025
TODO: We need to downcast objects as well. Downcast requires send and sync but it's not implemented for objects for some reason. |
<small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
…g/dafny into fix-5969-sync-for-rust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
run-integration-tests
Forces running the CI for integration tests even if the deep tests fail
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5969
What was changed?
--rust-sync
, set tofalse
by default. When turned on, all the generated code usesstd::sync::Arc
instead ofstd::rc::Rc
. Nothing else is normally needed for generated code.--include-runtime=true
now emits the runtime when translating to Rust.feature = "sync"
, enabling or disabling some functions via#[cfg(feature = "sync")]
and#[cfg(not(feature = "sync"))]
. Regular tests don't use this feature.cargo fmt
on the runtime.How has this been tested?
comp/rust/arc/tokiouser.dfy
uses this option and the runtime with the sync feature, compiled with--rust-sync
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.