Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include conditions from code in related location error messages #6008

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

keyboardDrummer
Copy link
Member

@keyboardDrummer keyboardDrummer commented Dec 27, 2024

In #5983 some code was commented out. It seems like this code was not running for either IDE or CLI, since it was guarded by !showSnippets && token.IncludesRange. For the IDE the !showSnippets condition was always false and for the CLI either of the two would be false.

This PR uncomments the code and sets showSnippets to false instead of true for the IDE, which I think only affects this one piece of code.

What was changed?

  • Remove the field TranslatorFlags.ReportRanges and related code, since it was unused.
  • Instead of this is the postcondition that could not be proved, say this postcondition might not hold: {postcondition},
  • Instead of this proposition could not be proved, say could not prove: {condition}

How has this been tested?

  • Many IDE and CLI tests test this behavior and they have been updated

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@keyboardDrummer keyboardDrummer changed the title Could not prove Include conditions from code in related location error messages Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant