Chore: Make snapshots to work on Windows #6005
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made that change intentionally at the time to fix an issue on macOS. Does git on Windows not support SSH? |
Hum it does not unfortunately. Let me do something that will work for both then. |
MikaelMayer
commented
Dec 26, 2024
MikaelMayer
commented
Dec 26, 2024
fabiomadge
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the docs/make-snapshot script.
How has this been tested?
The original script was not working on my windows machine. The updated sentences worked for me and I'm pretty sure they will work for anyone.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.