Renamed INode.RangeToken property to .Origin #5974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyboardDrummer
changed the title
robin-aws
requested changes
Dec 11, 2024
.github/workflows/doc-tests.yml
Outdated
| @@ -30,6 +30,10 @@ jobs: | |||
| uses: actions/setup-dotnet@v4 | |||
| with: | |||
| dotnet-version: 6.0.x | |||
There was a problem hiding this comment.
Probably want to delete the first copy :)
There was a problem hiding this comment.
I've tried various combinations and the one that works is to install both 6 and 8
There was a problem hiding this comment.
Oh! So it's something about building and running with different versions?
In that case add comments instead. As is it just looks unintentional and someone will 100% remove it later.
.github/workflows/runtime-tests.yml
Outdated
| - name: Setup dotnet | ||
| uses: actions/setup-dotnet@v4 | ||
| with: | ||
| dotnet-version: ${{env.dotnet-version}} |
There was a problem hiding this comment.
Definitely delete the first copy (and the useless env)!
There was a problem hiding this comment.
What do you mean? I'm purposefully installing both 8 and 6, so I'm invoking actions/setup-dotnet@v4 twice
robin-aws
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts changes from #5931 to make that one simpler to review
What was changed?
INode.RangeTokenproperty to .Origin.How has this been tested?
Pure refactoring
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.