Skip to content

Commit

Permalink
switch implementation of sind to use ScalarUDFImpl
Browse files Browse the repository at this point in the history
  • Loading branch information
dadepo committed Apr 20, 2024
1 parent 55da90b commit c5a03a6
Show file tree
Hide file tree
Showing 2 changed files with 49 additions and 28 deletions.
60 changes: 47 additions & 13 deletions src/postgres/math_udfs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -100,22 +100,56 @@ pub fn asind(args: &[ArrayRef]) -> Result<ArrayRef> {
}

/// Sine, argument in degrees.
pub fn sind(args: &[ArrayRef]) -> Result<ArrayRef> {
let values = datafusion::common::cast::as_float64_array(&args[0])?;
let mut float64array_builder = Float64Array::builder(args[0].len());
#[derive(Debug)]
pub struct Sind {
signature: Signature,
}

values.iter().try_for_each(|value| {
if let Some(value) = value {
let result = value.to_radians().sin();
float64array_builder.append_value(result);
Ok::<(), DataFusionError>(())
} else {
float64array_builder.append_null();
Ok::<(), DataFusionError>(())
impl Sind {
pub fn new() -> Self {
Self {
signature: Signature::uniform(1, vec![Float64], Volatility::Immutable),
}
})?;
}
}

Ok(Arc::new(float64array_builder.finish()) as ArrayRef)
impl ScalarUDFImpl for Sind {
fn as_any(&self) -> &dyn std::any::Any {
self
}

fn name(&self) -> &str {
"sind"
}

fn signature(&self) -> &Signature {
&self.signature
}

fn return_type(&self, _arg_types: &[DataType]) -> Result<DataType> {
Ok(Float64)
}

fn invoke(&self, args: &[ColumnarValue]) -> Result<ColumnarValue> {
let args = ColumnarValue::values_to_arrays(args)?;
let values = datafusion::common::cast::as_float64_array(&args[0])?;
let mut float64array_builder = Float64Array::builder(args[0].len());

values.iter().try_for_each(|value| {
if let Some(value) = value {
let result = value.to_radians().sin();
float64array_builder.append_value(result);
Ok::<(), DataFusionError>(())
} else {
float64array_builder.append_null();
Ok::<(), DataFusionError>(())
}
})?;

Ok(ColumnarValue::Array(
Arc::new(float64array_builder.finish()) as ArrayRef,
))
}
}

/// Inverse tangent, result in degrees.
Expand Down
17 changes: 2 additions & 15 deletions src/postgres/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use datafusion::physical_expr::functions::make_scalar_function;
use datafusion::prelude::SessionContext;

use crate::postgres::math_udfs::{
acosd, asind, cosd, cotd, sind, Atand, Ceiling, Div, Erf, Erfc, RandomNormal, Tand,
acosd, asind, cosd, cotd, Atand, Ceiling, Div, Erf, Erfc, RandomNormal, Sind, Tand,
};
use crate::postgres::network_udfs::{
broadcast, family, host, hostmask, inet_merge, inet_same_family, masklen, netmask, network,
Expand All @@ -31,7 +31,7 @@ fn register_math_udfs(ctx: &SessionContext) -> Result<()> {
register_cosd(ctx);
register_cotd(ctx);
register_asind(ctx);
register_sind(ctx);
ctx.register_udf(ScalarUDF::from(Sind::new()));
ctx.register_udf(ScalarUDF::from(Atand::new()));
ctx.register_udf(ScalarUDF::from(Tand::new()));
ctx.register_udf(ScalarUDF::from(Ceiling::new()));
Expand Down Expand Up @@ -68,19 +68,6 @@ fn register_asind(ctx: &SessionContext) {
ctx.register_udf(asind_udf);
}

fn register_sind(ctx: &SessionContext) {
let sind_udf = make_scalar_function(sind);
let return_type: ReturnTypeFunction = Arc::new(move |_| Ok(Arc::new(Float64)));
let sind_udf = ScalarUDF::new(
"sind",
&Signature::uniform(1, vec![Float64], Volatility::Immutable),
&return_type,
&sind_udf,
);

ctx.register_udf(sind_udf);
}

fn register_cosd(ctx: &SessionContext) {
let cosd_udf = make_scalar_function(cosd);
let return_type: ReturnTypeFunction = Arc::new(move |_| Ok(Arc::new(Float64)));
Expand Down

0 comments on commit c5a03a6

Please sign in to comment.