ImpersonateUser fix

[bscheshirwork]

dektrium#893

[d4rkstar]

Hello, why actually adding this $model->isAdmin check here?
Usually $model will be the user cycled in the grid row: so $model->isAdmin will be true only for admin users.
Result: the button will not be displayed if the gridrow contains a normal user (read: the button "impersonate" will not be shown).

[bscheshirwork]

@d4rkstar

Result: the button will not be displayed if the gridrow contains a normal user (read: the button "impersonate" will not be shown).

this is correct behavior. Impersonate available only on "admin". See origin thread discussion

[d4rkstar]

I insist: "The impersonate should be available to admin with access to all other users."

So: $model will be the user cycled in the grid row: so $model->isAdmin will be true only for admin users.

This will break the behavior you said.

[bscheshirwork]

i.e.

$model->isAdmin 

should be replace to

\Yii::$app->user->identity->isAdmin 

?

[bscheshirwork]

isAdmin
after
dektrium@b7180b2

[bscheshirwork]

before this commit $someuser->isAdmin has used wrong behavior (correct for this case)

Thanks.

[bscheshirwork]

So... but in this fork I can see old code

yii2-user/models/User.php

Line 125 in 4805971

\Yii::$app->user->can($this->module->adminPermission) : false)

                \Yii::$app->user->can($this->module->adminPermission) : false)

instead of

                \Yii::$app->authManager->checkAccess($this->id, $this->module->adminPermission) : false)

@d4rkstar you sure use this fork?

[d4rkstar]

After a composer update all went fine :) Thank you!