Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPSH-1541 #354

Closed
wants to merge 6 commits into from
Closed

SPSH-1541 #354

wants to merge 6 commits into from

Conversation

YoussefBouch
Copy link
Contributor

Description

Links to Tickets or other PRs

Notes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

tikle-cap and others added 6 commits November 28, 2024 09:33
Spsh 1494
SPSH-1493
* Tab navigation for the result table

* Added a unit test
* moved error alert into form wrapper and hide close button on error

* fixed rolle creation test

* implemented spsh alert into formwrapper in rolle and klassen details

* fixed tests

* more spacing for spsh alert

* added condition for wrapping container

* removed metadata reset to be able to trigger unsaved changes dialog

* fixed error behaviour for klasse edit

* reset error code after confirming unsaved changes

* use condition to flush form

---------

Co-authored-by: Youssef Bouchara <[email protected]>
@YoussefBouch YoussefBouch deleted the SPSH-1541 branch November 29, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants