SPSH-1532 #352
Merged
SPSH-1532 #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaggarnaut
approved these changes
Nov 29, 2024
|
PR zeigt auf main, bitte von release rebasen |
HKayed
pushed a commit
that referenced
this pull request
Jan 14, 2025
* Using a unique combination as Id for the map * fixed logic * Removed limit from composable and added it to our requests * Fixed centering * Fixed tests * Fixed limit * Removed test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue was the key of the map was using "schuleId" which isn't unique since many Zuordnung could have the same sskId...
Solution: Using a unique key which is the combination of sskId + rolle + klasse.
Also removed the limit of 25 from the composable and added it to our requests.
Links to Tickets or other PRs
Notes
Approval for review