OPS-5160 Trigger infra-dev rollout on push to main #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aimee-889
reviewed
Oct 11, 2023
| with: | ||
| job_id: 33 | ||
| secrets: | ||
| AWX_TOKEN: ${{ secrets.AWX_TOKEN }} |
There was a problem hiding this comment.
is this necessary? The version of the terraform modules is set in infra-schulcloud as variable in the new approach, so this execution would not test anything new would it?
There was a problem hiding this comment.
That's a good point, but maybe we should always use the latest version on infra-dev to catch issues early. Otherwise we would need to think of a way to have different versions of the Terraform modules on infra-dev and on the other stages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other PRs
Notes
Approval for review