Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPS-5263 Added opentelekomcloud-csv-to-dns module #7

Merged
merged 5 commits into from
Oct 10, 2023

Conversation

simoncolincap
Copy link
Contributor

Description

Links to Tickets or other PRs

Notes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@simoncolincap simoncolincap requested a review from a team October 9, 2023 11:17
@simoncolincap simoncolincap self-assigned this Oct 9, 2023
@@ -0,0 +1,15 @@
resource "opentelekomcloud_dns_recordset_v2" "email_hpi_schul_cloud_de" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resource name should be more general

@@ -0,0 +1,9 @@
variable "file_path" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

csv_file_path would be better

@simoncolincap simoncolincap merged commit 6ca3d9f into main Oct 10, 2023
@simoncolincap simoncolincap deleted the OPS-5263-integrate-email-dns-records-in-terraform branch October 10, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants