Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ops-5171-ionos-k8s-version #4

Merged
merged 4 commits into from
Sep 27, 2023
Merged

ops-5171-ionos-k8s-version #4

merged 4 commits into from
Sep 27, 2023

Conversation

sahassou
Copy link
Contributor

Description

In order to delete the node pool properly, we need to retrieve the Nodepool ID from Terraform output. I made some changes in ionos-k8s-cluster so that I can have the Nodepool ID as output.

Links to Tickets or other PRs

Notes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@sahassou sahassou requested review from dimapin, aimee-889 and a team September 25, 2023 12:43
@sahassou sahassou self-assigned this Sep 25, 2023
@aimee-889
Copy link
Contributor

Regarding the failing checkov checks, we decided that it is okay to use tags when using modules that are maintained by us. We currently do not use any modules that are not maintained by us, however if we ever should do so, a hash should be used as reference. Regarding the checkov check, we want to disable it. This can be done by adding this line to the GHA:
skip_check: CKV_TF_1. See https://github.com/bridgecrewio/checkov-action for reference :)

@sahassou
Copy link
Contributor Author

To delete the node pool properly, we need to retrieve the Nodepool ID from Terraform output. I have made some changes in ionos-k8s-cluster to obtain the Nodepool ID as output. 'nodepool_zone[*]' is a list of node pools, and '' indicates that we are going to delete all the node pools inside this zone.

@sahassou sahassou merged commit 8392da4 into main Sep 27, 2023
@aimee-889 aimee-889 deleted the ops-5171-ionos-k8s-cluster branch May 28, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants