Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBP-933-support-spsh-with-ldap-migration #34

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

aimee-889
Copy link
Contributor

Description

This PR:

  • fixes output of public ips for Scaling Nodepools
  • adds the option to add labels to non Scaling Nodepools (Taints are not set for all legacy Nodes since purpose is "" and is therefore skipped by the Node Taint Job that runs every 5 minutes on most clusters)
  • Changes the naming conventions for custom nodepools, that are not scaling, to mitigate a problem with the cidr_wrkaround module (it fails when nodes have no "nodepool" in name)

This PR has no reaking changes IF there are no other existing nodepools that use the custom nodepool list, but not for scaling purposes. Please tell me if such Nodepools should exist.

Links to Tickets or other PRs

Notes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@aimee-889 aimee-889 requested a review from a team August 6, 2024 12:16
@aimee-889 aimee-889 self-assigned this Aug 6, 2024
@aimee-889 aimee-889 merged commit a934c2f into main Aug 9, 2024
2 checks passed
@aimee-889 aimee-889 deleted the DBP-933-support-spsh-with-ldap-migration branch August 9, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants